Upgrade to Liquibase 3.6.2 #13625

72MiguelGomes · 2018-06-30T20:40:27Z

The new version of SpringLiquibase was not released yet, but will add this PR here, and as soon as the new version is available we just need to update it and merge.

Issue: #13550.

This PR should keep on hold for a little. @isopov as soon as the new version was released please update us.

72MiguelGomes · 2018-06-30T20:41:56Z

spring-boot-project/spring-boot-dependencies/pom.xml

 		<kotlin.version>1.2.41</kotlin.version>
 		<lettuce.version>5.1.0.M1</lettuce.version>
-		<liquibase.version>3.6.1</liquibase.version>
+		<liquibase.version>3.6.2-SNAPSHOT</liquibase.version>


Please note this was used just to test, we must remove the SNAPSHOTas soon as the new versions is available

isopov · 2018-07-05T10:08:56Z

@72MiguelGomes 3.6.2 liqubiase version has been released

snicoll

Thanks for the PR. Note that when adding new configuration keys, the appendix in the doc must be upgraded as well.

Do any of those have a default value? If so, it's a bit dangerous to override them with null. It would be nice also to expose those default values in the metadata (by initializing the field).

snicoll · 2018-07-09T12:18:40Z

...gure/src/main/java/org/springframework/boot/autoconfigure/liquibase/LiquibaseProperties.java

+	private String liquibaseTablespace;
+
+	/**
+	 * Database changelog table.


table name?

What do you mean? I am using the same that used in liquibase project

I mean that the description can be more informative.

In GlobalConfiguration the description is

Name of table to use for tracking change history

which is way more informative than the Javadoc. I prefer to use that

72MiguelGomes · 2018-07-11T19:07:15Z

@snicoll thanks for the feedback, will update it asap.

Issue: spring-projects#13550

72MiguelGomes · 2018-07-12T21:10:38Z

@snicoll Those values does not have any default value define, so there is no problem.

https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/integration/spring/SpringLiquibase.java#L81

Regarding de adoc, do you know if is possible generate that automatically during the build or is it always a manual process?

@philwebb The PR is ready to merge, please let me know if you find something that is missing.

@isopov Thanks for letting me know about liquibase release.

snicoll · 2018-07-13T06:01:18Z

@snicoll Those values does not have any default value define, so there is no problem.

uh? Surely there must be some sort of default somewhere right? SpringLiquibase is just a wrapper, the default value is set in GlobalConfiguration.

Regarding de adoc, do you know if is possible generate that automatically during the build or is it always a manual process?

That's how it is right now, you can subscribe to #8237.

snicoll · 2018-07-13T06:05:10Z

spring-boot-project/spring-boot-docs/src/main/asciidoc/appendix-application-properties.adoc

 	spring.liquibase.contexts= # Comma-separated list of runtime contexts to use.
 	spring.liquibase.default-schema= # Default database schema.
+	spring.liquibase.liquibase-schema= # Liquibase database schema.
+  spring.liquibase.liquibase-tablespace= # Liquibase tablespace.


There is an indentation problem here.

snicoll · 2018-07-13T06:30:43Z

@72MiguelGomes please don't act on the default value as I'd like to do this globally (#13765).

Can you please fix the indentation and use a better description for those new keys?

See gh-13625

…quibase3.6.2 * pr/13625: Polish "Upgrade to Liquibase 3.6.2" Upgrade to Liquibase 3.6.2

snicoll · 2018-07-13T09:43:29Z

@72MiguelGomes thank you, this is now merged in master.

DanielFran · 2018-07-17T16:47:49Z

@snicoll Is it possible to include this to next 2.0.4 release too?

It should include those 4 PRs:
#13145
#13159
#13625
#13765

wilkinsona · 2018-07-17T16:59:24Z

Unfortunately not. 2.0.x uses Liquibase 3.5.x and we won't upgrade to a new minor release of Liquibase in a maintenance release of Spring Boot.

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 30, 2018

72MiguelGomes commented Jun 30, 2018

View reviewed changes

72MiguelGomes mentioned this pull request Jun 30, 2018

Add support for new SpringLiquibase properties from 3.6.2 #13550

Closed

72MiguelGomes force-pushed the 13550/AddSupportSpringLiquibase3.6.2 branch from 79804f7 to 61be918 Compare July 1, 2018 00:18

philwebb added type: enhancement A general enhancement for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 1, 2018

philwebb added this to the Backlog milestone Jul 1, 2018

snicoll reviewed Jul 9, 2018

View reviewed changes

snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jul 9, 2018

72MiguelGomes force-pushed the 13550/AddSupportSpringLiquibase3.6.2 branch from 61be918 to 65cc3ab Compare July 12, 2018 21:01

Add support for new SpringLiquibase properties from 3.6.2

903e3ab

Issue: spring-projects#13550

72MiguelGomes force-pushed the 13550/AddSupportSpringLiquibase3.6.2 branch from 65cc3ab to 903e3ab Compare July 12, 2018 21:06

snicoll reviewed Jul 13, 2018

View reviewed changes

snicoll mentioned this pull request Jul 13, 2018

Properly document liquibase's default #13765

Closed

Improve Liquibase Documenatation and fix identation

f780439

72MiguelGomes force-pushed the 13550/AddSupportSpringLiquibase3.6.2 branch from 5b39aa3 to f780439 Compare July 13, 2018 08:23

snicoll changed the title ~~Add support for new SpringLiquibase properties from 3.6.2~~ Upgrade to Liquibase 3.6.2 Jul 13, 2018

snicoll self-assigned this Jul 13, 2018

snicoll removed the status: waiting-for-feedback We need additional information before we can continue label Jul 13, 2018

snicoll modified the milestones: Backlog, 2.1.0.M1 Jul 13, 2018

snicoll pushed a commit that referenced this pull request Jul 13, 2018

Upgrade to Liquibase 3.6.2

b5cb074

See gh-13625

snicoll closed this in 4c7c328 Jul 13, 2018

snicoll added a commit that referenced this pull request Jul 13, 2018

Merge pull request #13625 from 72MiguelGomes:13550/AddSupportSpringLi…

dade7cc

…quibase3.6.2 * pr/13625: Polish "Upgrade to Liquibase 3.6.2" Upgrade to Liquibase 3.6.2

DanielFran mentioned this pull request Jul 24, 2018

WIP: Maven Liquibase changelog generation for h2disk jhipster/generator-jhipster#8019

Closed

4 tasks

Upgrade to Liquibase 3.6.2 #13625

Upgrade to Liquibase 3.6.2 #13625

Uh oh!

Conversation

72MiguelGomes commented Jun 30, 2018

Uh oh!

72MiguelGomes Jun 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isopov commented Jul 5, 2018

Uh oh!

snicoll left a comment

Choose a reason for hiding this comment

Uh oh!

snicoll Jul 9, 2018

Choose a reason for hiding this comment

Uh oh!

72MiguelGomes Jul 12, 2018

Choose a reason for hiding this comment

Uh oh!

snicoll Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

snicoll Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

72MiguelGomes commented Jul 11, 2018

Uh oh!

72MiguelGomes commented Jul 12, 2018

Uh oh!

snicoll commented Jul 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snicoll Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

72MiguelGomes Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

snicoll commented Jul 13, 2018

Uh oh!

snicoll commented Jul 13, 2018

Uh oh!

DanielFran commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilkinsona commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

72MiguelGomes Jun 30, 2018 •

edited

Loading

snicoll commented Jul 13, 2018 •

edited

Loading

DanielFran commented Jul 17, 2018 •

edited

Loading